Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/nested/manual/recovery-system-reboot: disable disk encryption #15025

Conversation

valentindavid
Copy link
Contributor

This a temporary measure since pc-kernel in store does not have a fresh enough snap-bootstrap.

Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?

This a temporary measure since pc-kernel in store does not have a
fresh enough snap-bootstrap.
@valentindavid valentindavid added the FDE Manager Pull requests that target FDE manager branch label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (fde-manager-features@407bebd). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             fde-manager-features   #15025   +/-   ##
=======================================================
  Coverage                        ?   78.14%           
=======================================================
  Files                           ?     1171           
  Lines                           ?   156048           
  Branches                        ?        0           
=======================================================
  Hits                            ?   121948           
  Misses                          ?    26539           
  Partials                        ?     7561           
Flag Coverage Δ
unittests 78.14% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Member

@andrewphelpsj andrewphelpsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pedronis pedronis merged commit 5f0d238 into canonical:fde-manager-features Feb 4, 2025
64 of 66 checks passed
Copy link

github-actions bot commented Feb 4, 2025

Tue Feb 4 18:23:47 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13139749690

Failures:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FDE Manager Pull requests that target FDE manager branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants